fix(crons): Pass correct event types, fix checkin_margin field, add example #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 80.51% 80.56% +0.04%
==========================================
Files 43 44 +1
Lines 4450 4460 +10
==========================================
+ Hits 3583 3593 +10
- Misses 734 736 +2
+ Partials 133 131 -2
☔ View full report in Codecov by Sentry. |
cleptric
approved these changes
Jul 26, 2023
| @@ -80,7 +80,7 @@ type MonitorConfig struct { //nolint: maligned // prefer readability over optima | |||
| Schedule MonitorSchedule `json:"schedule,omitempty"` | |||
| // The allowed margin of minutes after the expected check-in time that | |||
| // the monitor will not be considered missed for. | |||
| CheckInMargin int64 `json:"check_in_margin,omitempty"` | |||
| CheckInMargin int64 `json:"checkin_margin,omitempty"` | |||
There was a problem hiding this comment.
Hmm, this almost looks like a typo to me. Will raise with the Crons team.
| MonitorSlug: monitorSlug, | ||
| Status: status, | ||
| }, | ||
| nil, |
There was a problem hiding this comment.
I don't know if this causes issues. In Laravel, we sent the monitor config along for all check-ins.
There was a problem hiding this comment.
It sorta feels natural to me: when the monitor already exists (guaranteed by the first check-in), we don't have to pass in the monitor config anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #661 that fixes a few issues and also adds an E2E example.
check_in_margin->checkin_margin(https://develop.sentry.dev/sdk/check-ins/#monitor-upsert-support)checkinType